Skip to content

Store CLArray offset in bytes instead of elements#427

Merged
maleadt merged 1 commit into
masterfrom
tb/offset
Apr 10, 2026
Merged

Store CLArray offset in bytes instead of elements#427
maleadt merged 1 commit into
masterfrom
tb/offset

Conversation

@maleadt
Copy link
Copy Markdown
Member

@maleadt maleadt commented Apr 10, 2026

The element-based offset was lossy when materializing reinterpret on views with non-aligned offsets (e.g., reinterpreting a view of Int32 as Int64). The byte offset would get truncated by integer division when converting to the new element count.

x-ref JuliaGPU/CUDA.jl#2980

The element-based offset was lossy when materializing reinterpret on
views with non-aligned offsets (e.g., reinterpreting a view of Int32
as Int64). The byte offset would get truncated by integer division
when converting to the new element count.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.13%. Comparing base (f23032b) to head (64965e8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/array.jl 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   80.34%   80.13%   -0.22%     
==========================================
  Files          12       12              
  Lines         743      745       +2     
==========================================
  Hits          597      597              
- Misses        146      148       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt
Copy link
Copy Markdown
Member Author

maleadt commented Apr 10, 2026

CI failures unrelated.

@maleadt maleadt merged commit edfa2c4 into master Apr 10, 2026
23 of 38 checks passed
@maleadt maleadt deleted the tb/offset branch April 10, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant