Repository navigation
Fix Flat-Ground TM Receiver Sampling in 2D Forward Solver - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flat-ground TM receiver sampling in the 2D forward solver
What was wrong
On flat ground, TM Ey at a station was interpolated between the cell-centre Ey values of the neighbouring cells. Those values leave out the lateral ∂Ez/∂y term. Ey is also discontinuous at a vertical resistivity contact, so interpolating it across a contact mixes the two resistivities. The computed TM field was correct; only the value read at the station was wrong. 1D models are unaffected, which is why half-space and layered checks never caught it. Near lateral contrasts the TM impedance error was large and depended on the mesh: up to 218% on a coarse mesh and 12.6% on a fine mesh for a surface conductor.
What was fixed
_mt2d_tm_receiver_ey, used by both_mt2d_station_impedanceandcompute_fields_at_receivers_tm.Validation
test/TestForward2D.jl: the exact field at a 10/100 Ωm contact, on uniform and nonuniform cells, with stations on the contact and on nodes. The old code was off by 225% and 327%; the new code matches to 1e-10 relative.Note
Stored TM responses near lateral contrasts that were generated with the old sampling will change.