Skip to content

change pseudorapidity limits to Inf#42

Merged
graeme-a-stewart merged 2 commits into
mainfrom
eta_clamp
May 4, 2026
Merged

change pseudorapidity limits to Inf#42
graeme-a-stewart merged 2 commits into
mainfrom
eta_clamp

Conversation

@m-fila
Copy link
Copy Markdown
Member

@m-fila m-fila commented May 1, 2026

Related issues

Closes #40

Checklist

  • Tests are passing
  • Docs were updated and workflow is passing

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.38%. Comparing base (aed7506) to head (299994a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files           5        5           
  Lines         136      136           
=======================================
  Hits          127      127           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! I just have one comment about implicit type conversion.

Comment thread src/coordinate_systems/XYZT.jl Outdated
@szabo137
Copy link
Copy Markdown
Member

szabo137 commented May 4, 2026

LGTM! Feel free to merge.

Copy link
Copy Markdown
Member

@graeme-a-stewart graeme-a-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @m-fila !

@graeme-a-stewart graeme-a-stewart merged commit d4e4a56 into main May 4, 2026
6 checks passed
@m-fila m-fila deleted the eta_clamp branch May 4, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maximum rapidity values are inconsistent and obscure

3 participants