Skip to content

Add tests for pipeline instrumentation#553

Open
vchuravy wants to merge 3 commits into
mainfrom
vc/pipeline-instrumentation
Open

Add tests for pipeline instrumentation#553
vchuravy wants to merge 3 commits into
mainfrom
vc/pipeline-instrumentation

Conversation

@vchuravy
Copy link
Copy Markdown
Collaborator

After I got myself confused in #551 I thought I should add some tests
showing that I was quite wrong.

    Test that LLVM command-line flags passed via JULIA_LLVM_ARGS are
    propagated to the NewPM pipeline through StandardInstrumentations:

    - --print-after-all --filter-print-funcs=SomeFunction: function-level
      pass (NoOpFunctionPass) respects isFunctionInPrintList()
    - --print-changed=diff-quiet --filter-passes=globaldce: GlobalDCEPass
      removes a dead internal global and produces a diff; filter-passes
      uses the pipeline-facing name (globaldce, not GlobalDCEPass)
    - Custom Julia function pass (NewPMFunctionPass) is visible to pass
      instrumentation under its registered name

    Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vchuravy vchuravy force-pushed the vc/pipeline-instrumentation branch from 9c7e336 to f09909d Compare April 27, 2026 10:03
Comment thread test/newpm.jl
Comment thread test/newpm.jl Outdated
Comment thread test/newpm.jl Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   85.92%   83.01%   -2.91%     
==========================================
  Files          47       46       -1     
  Lines        2955     2826     -129     
==========================================
- Hits         2539     2346     -193     
- Misses        416      480      +64     

see 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread test/newpm.jl Outdated
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
@vchuravy vchuravy marked this pull request as ready for review April 27, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support PassInstrumentationCallbacks for Julia driven optimization pipelines

2 participants