Add tests for pipeline instrumentation#553
Open
vchuravy wants to merge 3 commits into
Open
Conversation
Test that LLVM command-line flags passed via JULIA_LLVM_ARGS are
propagated to the NewPM pipeline through StandardInstrumentations:
- --print-after-all --filter-print-funcs=SomeFunction: function-level
pass (NoOpFunctionPass) respects isFunctionInPrintList()
- --print-changed=diff-quiet --filter-passes=globaldce: GlobalDCEPass
removes a dead internal global and produces a diff; filter-passes
uses the pipeline-facing name (globaldce, not GlobalDCEPass)
- Custom Julia function pass (NewPMFunctionPass) is visible to pass
instrumentation under its registered name
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
9c7e336 to
f09909d
Compare
vchuravy
commented
Apr 27, 2026
vchuravy
commented
Apr 27, 2026
vchuravy
commented
Apr 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 85.92% 83.01% -2.91%
==========================================
Files 47 46 -1
Lines 2955 2826 -129
==========================================
- Hits 2539 2346 -193
- Misses 416 480 +64 see 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
vchuravy
commented
Apr 27, 2026
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
maleadt
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After I got myself confused in #551 I thought I should add some tests
showing that I was quite wrong.