Use 3-arg LLVM.lookup to avoid deprecation warning#102
Merged
gbaraldi merged 1 commit intoMay 15, 2026
Conversation
LLVM.jl v9.8.1 deprecated the 2-arg `lookup(jljit::JuliaOJIT, name)` form in favor of `lookup(jljit, jd, name)` (the old form was removed in JuliaLang/julia#60988 for Julia 1.14.0-DEV.2171). The depwarn fired during the JIT lookup inside `@check_allocs`-generated code, which caused downstream packages testing `@check_allocs` with `@test_nowarn` to fail. Pass the already-constructed `jd::JITDylib` explicitly. Bumps LLVM compat to 9.8.1 since the 3-arg JuliaOJIT method was added in that release. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
|
Looks like a reasonable depwarn fix to me. @topolarity or @gbaraldi |
Member
|
Did this get a tag? I'm still seeing downstream failures. |
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/LinearSolve.jl
that referenced
this pull request
May 20, 2026
AllocCheck v0.2.4 was released 2026-05-20 with the fix from JuliaLang/AllocCheck.jl#102 ("Use 3-arg LLVM.lookup to avoid deprecation warning"). This unblocks the NoPre test group on LinearSolve, which had been red on every PR for 8 days due to AllocCheck 0.2.3 triggering an LLVM.jl 9.8.1 depwarn that `@test_nowarn` in test/nopre/static_arrays.jl correctly captured. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLVM.jl v9.8.1 (released 2026-05-12) added an
@deprecatefor the 2-arglookup(jljit::JuliaOJIT, name)form in favor of the new 3-arglookup(jljit, jd, name). The old form was removed upstream in JuliaLang/julia#60988 for Julia 1.14.0-DEV.2171.src/compiler.jl:114callsLLVM.lookup(lljit, entry_name)from inside the@check_allocs-generated link path, so the depwarn fires at every JIT lookup. Downstream packages that exercise@check_allocsunder@test_nowarnsee the warning surface as a test failure — see SciML/LinearSolve.jl#984 (test/nopre/static_arrays.jl:25).Fix
jd::JITDylibexplicitly:LLVM.lookup(lljit, jd, entry_name).9.1→9.8.1because the 3-arglookup(::JuliaOJIT, ::JITDylib, ::Any)method was first introduced in v9.8.1.0.2.3→0.2.4.Verification
Local on Julia 1.11.9 with LLVM.jl v9.8.1:
Pkg.test()passes (all suites green).@check_allocsround-trip under--depwarn=errorruns cleanly — confirming the deprecation warning is gone.Test plan
LLVM.lookupdepwarn under--depwarn=errortest/nopre/static_arrays.jlpasses once a tagged release of AllocCheck includes this fix