Skip to content

Reduce AbstractFFTs import latency#156

Open
Beforerr wants to merge 1 commit into
JuliaMath:masterfrom
Beforerr:fix/testutils-import-latency
Open

Reduce AbstractFFTs import latency#156
Beforerr wants to merge 1 commit into
JuliaMath:masterfrom
Beforerr:fix/testutils-import-latency

Conversation

@Beforerr
Copy link
Copy Markdown

@Beforerr Beforerr commented May 14, 2026

This removes the TestUtils.__init__ error-hint hook, which made using AbstractFFTs spend most of its time compiling even though the hook itself reported as 0.0 ms.

Instead, the test helpers now have small fallback methods that keep the friendly "Did you forget to load Test?" message. Once Test is loaded, the extension methods still take over.

On my machine, the import time dropped from about 75 ms to about 6 ms.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.73%. Comparing base (65b7fcb) to head (7f8be10).

Files with missing lines Patch % Lines
src/TestUtils.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   94.81%   93.73%   -1.09%     
==========================================
  Files           5        5              
  Lines         444      447       +3     
==========================================
- Hits          421      419       -2     
- Misses         23       28       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj
Copy link
Copy Markdown
Member

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants