Remove machine-precision stopping conditions - #1110
Open
amontoison wants to merge 1 commit into
Open
Conversation
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
+ Coverage 94.68% 97.67% +2.99%
==========================================
Files 45 50 +5
Lines 8027 10095 +2068
==========================================
+ Hits 7600 9860 +2260
+ Misses 427 235 -192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1109
I will wait one week before that I merge it.
I would like to think more about #1109 and be sure that it is the right solution.
Additional comment:
Krylov.jlhave +35 solvers for one right-hand side and only 21 solvers have this stopping condition that is not documented.If we decide to finally keep these stopping conditions, we should be consistent everywhere.