[documentation] Add a page about the foundations of Krylov methods - #593
Open
amontoison wants to merge 1 commit into
Open
[documentation] Add a page about the foundations of Krylov methods#593amontoison wants to merge 1 commit into
amontoison wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 35 35
Lines 5957 5957
=======================================
Hits 5841 5841
Misses 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
dpo
reviewed
Jun 21, 2022
dpo
left a comment
dpo
left a comment
Member
There was a problem hiding this comment.
Are the docs the right place to add such background? The background only talks about square systems. I think that if you really want some background in here, it should be less specific and more general: Krylov methods build approximations by constructing subspaces of increasing dimension and choosing the approximations using an optimization problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could give a link to this page to justify my message in this discussion: https://discourse.julialang.org/t/how-to-solve-this-ax-b-faster/81693/22