pass weights to standardization and test against glmnet - #101
Merged
AsafManela merged 2 commits intoJul 28, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 86.94% 92.03% +5.08%
==========================================
Files 8 8
Lines 1218 1167 -51
==========================================
+ Hits 1059 1074 +15
+ Misses 159 93 -66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ericphanson
commented
Jul 24, 2026
Comment on lines
+188
to
+189
| @test l.coefs ≈ gbeta rtol=1e-5 | ||
| @test l.b0 ≈ g.a0 rtol=1e-5 |
Contributor
Author
There was a problem hiding this comment.
here we are testing against glmnet (binary dependency of GLMNet.jl) so it is a good cross-check that this is working properly (following existing test practices here)
Collaborator
|
Solid work. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developed with claude sonnet 5 and checked by me