WIP: Get started on two dimensional regression#99
Open
RomeoV wants to merge 4 commits intoJuliaStats:masterfrom
Open
WIP: Get started on two dimensional regression#99RomeoV wants to merge 4 commits intoJuliaStats:masterfrom
RomeoV wants to merge 4 commits intoJuliaStats:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 86.03% 91.84% +5.80%
==========================================
Files 2 2
Lines 222 233 +11
==========================================
+ Hits 191 214 +23
+ Misses 31 19 -12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already infrastructure for multi-dimensional regression, except for the polynomial fitting.
This implements basic cubic regression in the two-dimensional case only.
Probably we can write even more general code for arbitrary dimensions, but it's not completely straight forward.
Also, currently the interface is a big mess (should the inputs be Tuples, Vector, SVectors)?
Nonetheless, I'm putting this here. Perhaps I will have more time to refine it - otherwise it may serve as an inspiration to others.