Handle tuples in build_function.jl - #1462
Open
5hv5hvnk wants to merge 1 commit into
Open
Conversation
Member
|
This would allocate though? |
Author
|
I think so, I can probably write some tests to verify? |
Member
|
Yes write some tests that check if the tuple route is non-allocating on simple functions. I don't think it would pass. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
=========================================
- Coverage 8.88% 7.70% -1.18%
=========================================
Files 51 51
Lines 4876 4943 +67
=========================================
- Hits 433 381 -52
- Misses 4443 4562 +119 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@AayushSabharwal how do this come into your changes to function building? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1438
Added a work around to treat tuples as array and then return a tuple by converting it to a list.
ToDo: