Skip to content

Specialize in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval) - #797

Open
jishnub wants to merge 4 commits into
JuliaSymbolics:masterfrom
jishnub:patch-1
Open

Specialize in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval)#797
jishnub wants to merge 4 commits into
JuliaSymbolics:masterfrom
jishnub:patch-1

Conversation

@jishnub

@jishnub jishnub commented Nov 30, 2022

Copy link
Copy Markdown

Along with JuliaMath/IntervalSets.jl#126, this helps avoid ambiguities such as in JuliaApproximation/ApproxFun.jl#847

Let's wait for a decision on JuliaMath/IntervalSets.jl#126 before this

Edit: I've updated this to define in for TypedEndpointsInterval. Adding IntervalSets as a dependency does not impact load times, as it's loaded by DomainSets anyway. While TypedEndpointsInterval is not exported by IntervalSets, it's quite a fundamental type as, among other things, Interval and ChebyshevInterval are subtypes of this.

With this PR, the following works:

julia> using Symbolics

julia> @variables x
1-element Vector{Num}:
 x

julia> using DomainSets

julia> x in ChebyshevInterval()
Symbolics.VarDomainPairing(x, -1.0..1.0 (Chebyshev))

@jishnub jishnub changed the title Specialize in(x::Num, I::AbstractInterval) Specialize in(x::Union{Sym,Term,Num}, I::AbstractInterval) Nov 30, 2022
@jishnub
jishnub marked this pull request as draft November 30, 2022 14:47
@jishnub jishnub changed the title Specialize in(x::Union{Sym,Term,Num}, I::AbstractInterval) Specialize in(x::Union{Sym,Term,Num}, I::TypedEndpointsInterval) Dec 1, 2022
@jishnub
jishnub marked this pull request as ready for review December 1, 2022 10:02
Comment thread Project.toml
@codecov-commenter

codecov-commenter commented Mar 17, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.81%. Comparing base (3bad882) to head (2ee927e).
⚠️ Report is 2169 commits behind head on master.

Files with missing lines Patch % Lines
src/domains.jl 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   76.83%   76.81%   -0.03%     
==========================================
  Files          26       26              
  Lines        3238     3239       +1     
==========================================
  Hits         2488     2488              
- Misses        750      751       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjione

Copy link
Copy Markdown

Is there some progress on that?
I would benefit from this being merged, enabling me to use SumOfSquares.jl together with ApproxFun.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants