⚡ Bolt: optimize multi-regional listing concurrency

.jules/bolt.md

@@ -1,5 +1,9 @@
 # Bolt's Journal
 
+## 2026-03-09 - Lock-Free Multi-Regional Listing Optimization
+**Learning:** Multi-regional listing operations that query multiple GCP regions concurrently can suffer from lock contention when multiple goroutines write to a single shared slice using a `sync.Mutex`. By pre-allocating an intermediate slice of slices `[][]T` and having each goroutine write directly to its corresponding region's index without locking, contention is entirely eliminated. Pre-allocating the final flat slice once the exact total size is known also avoids multiple dynamic slice reallocations.
+**Action:** Use a lock-free pre-allocated map-reduce pattern (`[][]T`) instead of a shared `sync.Mutex` and dynamic slice `[]T` for concurrent collection.
+
 ## 2026-03-08 - GCP Logging Client Caching & Connection Longevity
 **Learning:** Establishing the GCP Stackdriver Logging client requires repeated Google credential discovery and connection establishment, causing high latency (~300ms) inside a reactive TUI interface. Caching `logadmin.Client` instances via a project-aware map with thread-safe `sync.Mutex` ensures subsequent streaming and log extraction operations are instantaneous. Crucially, calling `Close()` on individual stream terminations must be a no-op to prevent premature teardown of connection pools shared across other active streaming views.
 **Action:** Keep GCP Logging clients cached globally by project and handle connection termination via a no-op `Close` method, while adding test-isolation resets in unit tests.

internal/run/api/domainmapping/domainmapping.go

@@ -50,25 +50,33 @@ func List(project, region string) ([]model.DomainMapping, error) {
 }
 
 func listAllRegions(project string) ([]model.DomainMapping, error) {
-	var (
-		mu             sync.Mutex
-		domainMappings []model.DomainMapping
-		wg             sync.WaitGroup
-	)
+	regions := api_region.List()
+	results := make([][]model.DomainMapping, len(regions))
+	var wg sync.WaitGroup
 
-	for _, region := range api_region.List() {
+	for i, region := range regions {
 		wg.Add(1)
-		go func(r string) {
+		go func(idx int, r string) {
 			defer wg.Done()
 			if dms, err := List(project, r); err == nil {
-				mu.Lock()
-				domainMappings = append(domainMappings, dms...)
-				mu.Unlock()
+				results[idx] = dms
 			}
-		}(region)
+		}(i, region)
 	}
 
 	wg.Wait()
+
+	// Pre-allocate final slice with exact total capacity to eliminate reallocation overhead
+	total := 0
+	for _, dms := range results {
+		total += len(dms)
+	}
+
+	domainMappings := make([]model.DomainMapping, 0, total)
+	for _, dms := range results {
+		domainMappings = append(domainMappings, dms...)
+	}
+
 	return domainMappings, nil
 }
 

internal/run/api/job/job.go

@@ -79,27 +79,35 @@ func mapJob(resp *runpb.Job, region string) model.Job {
 }
 
 func listAllRegions(project string) ([]model.Job, error) {
-	var (
-		mu   sync.Mutex
-		jobs []model.Job
-		wg   sync.WaitGroup
-	)
+	regions := api_region.List()
+	results := make([][]model.Job, len(regions))
+	var wg sync.WaitGroup
 
-	for _, region := range api_region.List() {
+	for i, region := range regions {
 		wg.Add(1)
-		go func(r string) {
+		go func(idx int, r string) {
 			defer wg.Done()
 			// Call List recursively for each region
 			// We ignore errors here to allow partial success (e.g. if one region is down or disabled)
 			if j, err := List(project, r); err == nil {
-				mu.Lock()
-				jobs = append(jobs, j...)
-				mu.Unlock()
+				results[idx] = j
 			}
-		}(region)
+		}(i, region)
 	}
 
 	wg.Wait()
+
+	// Pre-allocate final slice with exact total capacity to eliminate reallocation overhead
+	total := 0
+	for _, j := range results {
+		total += len(j)
+	}
+
+	jobs := make([]model.Job, 0, total)
+	for _, j := range results {
+		jobs = append(jobs, j...)
+	}
+
 	return jobs, nil
 }
 

internal/run/api/service/service.go

@@ -299,26 +299,34 @@ func UpdateTraffic(ctx context.Context, project, region, serviceName string, tar
 }
 
 func listAllRegions(project string) ([]model.Service, error) {
-	var (
-		mu       sync.Mutex
-		services []model.Service
-		wg       sync.WaitGroup
-	)
+	regions := api_region.List()
+	results := make([][]model.Service, len(regions))
+	var wg sync.WaitGroup
 
-	for _, region := range api_region.List() {
+	for i, region := range regions {
 		wg.Add(1)
-		go func(r string) {
+		go func(idx int, r string) {
 			defer wg.Done()
 			// Call List recursively for each region
 			// We ignore errors here to allow partial success (e.g. if one region is down or disabled)
 			if s, err := List(project, r); err == nil {
-				mu.Lock()
-				services = append(services, s...)
-				mu.Unlock()
+				results[idx] = s
 			}
-		}(region)
+		}(i, region)
 	}
 
 	wg.Wait()
+
+	// Pre-allocate the final slice with exact total capacity to eliminate reallocation overhead
+	total := 0
+	for _, s := range results {
+		total += len(s)
+	}
+
+	services := make([]model.Service, 0, total)
+	for _, s := range results {
+		services = append(services, s...)
+	}
+
 	return services, nil
 }

internal/run/api/workerpool/workerpool.go

@@ -111,27 +111,35 @@ func UpdateScaling(ctx context.Context, project, region, workerPoolName string,
 }
 
 func listAllRegions(project string) ([]model.WorkerPool, error) {
-	var (
-		mu          sync.Mutex
-		workerPools []model.WorkerPool
-		wg          sync.WaitGroup
-	)
+	regions := api_region.List()
+	results := make([][]model.WorkerPool, len(regions))
+	var wg sync.WaitGroup
 
-	for _, region := range api_region.List() {
+	for i, region := range regions {
 		wg.Add(1)
-		go func(r string) {
+		go func(idx int, r string) {
 			defer wg.Done()
 			// Call List recursively for each region
 			// We ignore errors here to allow partial success (e.g. if one region is down or disabled)
 			if wp, err := List(project, r); err == nil {
-				mu.Lock()
-				workerPools = append(workerPools, wp...)
-				mu.Unlock()
+				results[idx] = wp
 			}
-		}(region)
+		}(i, region)
 	}
 
 	wg.Wait()
+
+	// Pre-allocate final slice with exact total capacity to eliminate reallocation overhead
+	total := 0
+	for _, wp := range results {
+		total += len(wp)
+	}
+
+	workerPools := make([]model.WorkerPool, 0, total)
+	for _, wp := range results {
+		workerPools = append(workerPools, wp...)
+	}
+
 	return workerPools, nil
 }