Merged
Conversation
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes previously deprecated public API surface and cleanup related dependencies in pyvlx, aligning the codebase with the newer non-deprecated access patterns.
Changes:
- Removed deprecated
OpeningDevice.get_limitation()wrapper method and thedeprecateddecorator usage. - Removed deprecated/compatibility aliases and properties (e.g.,
WinkTime.BY_MANUFACTUERER,GetState.gateway_state/gateway_sub_state). - Dropped the runtime dependency on
Deprecatedand corrected a warning log message in node information retrieval.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pyvlx/opening_device.py | Removes deprecated get_limitation() API and associated decorator import. |
| src/pyvlx/const.py | Removes deprecated backwards-compat enum alias for wink time. |
| src/pyvlx/api/get_state.py | Removes deprecated properties exposing gateway state/substate directly. |
| src/pyvlx/api/get_all_nodes_information.py | Fixes warning message wording from “scenes” to “nodes”. |
| pyproject.toml | Removes Deprecated from runtime dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes code that's been deprecated before.