feat(cli): aggregate step authorization into top-level config field #1200
Merged
gastonyelmini merged 2 commits intomainfrom Apr 9, 2026
Merged
feat(cli): aggregate step authorization into top-level config field #1200gastonyelmini merged 2 commits intomainfrom
gastonyelmini merged 2 commits intomainfrom
Conversation
gastonyelmini
force-pushed
the
release-17.4.0
branch
from
cb720f7 to
2538360
Compare
Adds a top-level "authorization" field to the generated ingestion sources config that aggregates permissions, roles, oauthScopes, apis, endpoints, licenses, and documentationLinks from all integration steps, regardless of ingestionSourceId. Values are deduplicated and sorted. This enables downstream consumers like docs-v2 to generate complete authorization documentation without traversing childIngestionSources.
gastonyelmini
force-pushed
the
release-17.4.0
branch
from
5b3ae67 to
bcc1b94
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
gastonyelmini
changed the title
tom-foley-j1
approved these changes
Apr 9, 2026
VDubber
approved these changes
Apr 9, 2026
Contributor
VDubber
left a comment
VDubber
left a comment
There was a problem hiding this comment.
Review Summary
Clean, well-tested feature addition. The code correctly deduplicates, sorts, and conditionally omits the authorization field. Version bumps are consistent across all packages. No security, data volume, or performance concerns.
| Dimension | Score (1-5) | Rationale |
|---|---|---|
| Security risk | 1 | No auth, credential, or data exposure changes. CLI-time metadata only. |
| Data volume impact | 1 | No effect on runtime data pipelines. Adds a small field to a static config JSON. |
| Performance risk | 1 | Build-time CLI command processing a handful of steps. No runtime impact. |
Verdict: Approve with suggestions — see inline comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a top-level authorization field to the generated ingestionSourcesConfig.json that aggregates all authorization requirements from every integration step — regardless of whether the step has an ingestionSourceId or not.
Previously, authorization metadata was only available inside childIngestionSources, which excluded root steps (steps matched directly by ingestionSourceId) and steps without an ingestionSourceId (like fetch-account). This meant downstream consumers like docs-v2 could never generate complete authorization documentation.
The new field collects permissions, roles, oauthScopes, apis, endpoints, licenses, and documentationLinks from all steps, deduplicates them, and sorts them alphabetically. It is only present when at least one step declares authorization.