release workflow: build/copy the engine under its post-rename name (v1.1.0 tag build failed) - #512
Merged
Merged
Conversation
The #391 rename left release.yml building 'make glm' (an alias that now produces 'colibri') and then asserting/copying 'c/glm', which no longer exists. CI never catches this: only a tag push runs this workflow, so the v1.1.0 tag build failed on macOS at 'ls -lh glm' with the other jobs cancelled and the release skipped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.1.0 tag build failed before publishing anything:
release.ymlstill ranmake glmand thenls -lh glm/cp c/glm. Since #391 the alias builds a binary namedcolibri, so the macOS job died at thels, the other jobs were cancelled by fail-fast, and the release job was skipped (run).CI stays green through all of this because only a tag push executes this workflow — the same blind spot the v1.0.0 msys2 shell bug exploited, and exactly what the verify step in this file warns about.
Fix:
make colibri+ls -lh colibriin the build step,cp c/colibriin the package step — matching what ci.yml already does. The packaged filename inside the archive is unchanged (plaincolibri, per #508).After merge this needs to reach main and the
v1.1.0tag re-pointed (no release was published, so deleting and re-pushing the tag is safe).🤖 Generated with Claude Code