Metal: add _gs params for shared-expert and fused layer decode#589
Closed
RDouglasSharp wants to merge 1 commit into
Closed
Metal: add _gs params for shared-expert and fused layer decode#589RDouglasSharp wants to merge 1 commit into
RDouglasSharp wants to merge 1 commit into
Conversation
Extend coli_metal_layer_decode with per-weight group-size (gs) params for all attention weights (qa/qb/kva/kvb/o) and shared-expert weights (shg/shu/shd). Update bind_gemv, AttnW struct, encode_attention, and all shared-expert bind_gemv calls to forward gs. Update the colibri.c layer_forward_rows call site to supply the new args.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
coli_metal_layer_decodewith per-weight group-size (gs) parameters for all attention weights (qa/qb/kva/kvb/o) and shared-expert weights (shg/shu/shd). Updatebind_gemv,AttnW,encode_attention, and the three shared-expertbind_gemvcalls to forwardgs. Update thelayer_forward_rowscall site incolibri.c.Also includes the common
bind_gemv/AttnW/enccode_attention changes from PR #588 for self-contained compilation; the two patches will merge cleanly.