serve: wire Host allowlist through coli CLI - #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #606 added
--allowed-hostandCOLI_ALLOWED_HOSTStoopenai_server.py, butcoli serveandcoli webimportserve()directly and bypass that parser. The documented primary entry points therefore could not configure the reverse-proxy Host allowlist.Wire the existing allowlist through both CLI entry points, expose it in their help, and document the flag, environment variable, and reverse-proxy setup.
Validation
make -C c checkmake -C c cuda-test(not applicable)Compatibility