Confirm before removing a feed source - #40
Merged
Conversation
Removing a source was a single unguarded click next to the card that opens the source's items. It now goes through the existing ConfirmDialog, named after the source being removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CusPPhPYEkjx9SBwsJ6Yw9
JustWallage
marked this pull request as ready for review
August 9, 2026 05:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a source from feed settings was a single unguarded click, sitting right under the card body that opens the source's items — an easy misclick with no undo.
Changes
src/pages/FeedSettingsPage.tsx: the Remove button now opens the existingConfirmDialoginstead of firing the DELETE. One dialog for the page, keyed off aremoveSourceIdstate (same shape asopenSourceIdforSourceItemsDialog); the title names the source, and the description states what removal actually does — the feed stops fetching from it, and already-fetched items stay in the archive until the next refresh drops them from the feed.e2e/feeds.spec.ts: new spec covering both branches — Cancel keeps the source listed, confirming removes it.src/CLAUDE.md: notes that source removal is confirmed.Verification
pnpm check— green (162 unit tests).pnpm test:e2e— 38/38 passing.Generated by Claude Code