feat: replaced siwe to complete remove ethers - #149
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![justalab-agents[bot]](https://avatars.githubusercontent.com/u/159771991?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR migrates the codebase away from ethers and siwe dependencies in favor of viem, removing both as peer/root dependencies and updating all documentation examples to use viem/accounts equivalents (privateKeyToAccount, generatePrivateKey) with the correct signMessage({ message }) call signature. The most significant functional change is in the SignIn feature, where the previous custom verificationFallback logic (including manual EIP-1271 and signature v-value normalization via viem) has been replaced with a direct call to siwens.verify(), assuming that library now handles all verification paths internally. Note that the lockfile was not updated alongside the package.json dependency changes.
✅ No blocking issues found by the automated review — this is not a substitute for human review.
Ghadi8
changed the title
| env: | ||
| COMMIT_MSG: ${{ github.event.head_commit.message }} | ||
| run: | | ||
| TITLE=$(printf '%s' "$COMMIT_MSG" | head -n1) |
There was a problem hiding this comment.
[WARNING] agentic/bug
The regex '^feat(\(.+\))?!?:' matches both feat: (new feature) and feat!: (breaking change) and maps both to minor. Per Conventional Commits, feat!: (or fix!: below) signals a breaking change and should bump major. The ! case needs to be tested separately before the non-breaking path.
Suggested fix:
Split the conditional so breaking changes are caught first:
```yaml
if printf '%s' "$TITLE" | grep -qE '^(feat|fix)(\(.+\))?!:'; then
SPECIFIER=major
elif printf '%s' "$TITLE" | grep -qE '^feat(\(.+\))?:'; then
SPECIFIER=minor
else
SPECIFIER=patch
fi
<!-- justalab-agents:hash:cc8a6785b8bb -->
* fix(console): removed dapps, removed ethers, and enhancements (#144) * fix(console): deprecated dapps, removed ethers, and enhancements * fix: yarn * fix: ci build * fix: removed fully mapps * fix: yarn * fix: vercel build * fix: posthog enabled, enhanced events * feat: replaced siwe to complete remove ethers (#149)
This branch was successfully deployed
3 participants
No description provided.