feat: replaced siwe to complete remove ethers - #150
Conversation
* fix(console): deprecated dapps, removed ethers, and enhancements * fix: yarn * fix: ci build * fix: removed fully mapps * fix: yarn * fix: vercel build
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![justalab-agents[bot]](https://avatars.githubusercontent.com/u/159771991?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR fixes the PostHog analytics proxy configuration in next.config.js by routing static assets to eu-assets.i.posthog.com and event ingestion to eu.i.posthog.com (replacing the deprecated eu.posthog.com), and removes the fragile build-time IP-fetching logic that was used to set X-Forwarded-For headers. It also consolidates several sparse analytics event types into richer, well-documented payloads with location context fields, and merges DOCS_LINK_CLICKED/DASHBOARD_LINK_CLICKED into a single LINK_CLICKED event. Additionally, the release workflow gains commit-message parsing to automatically select minor vs patch version bumps — though breaking-change commits (feat!:) are silently treated as minor rather than major, which is a gap worth addressing.
| TITLE=$(printf '%s' "$COMMIT_MSG" | head -n1) | ||
| echo "Commit title: $TITLE" | ||
| if printf '%s' "$TITLE" | grep -qE '^feat(\(.+\))?!?:'; then | ||
| SPECIFIER=minor |
There was a problem hiding this comment.
[WARNING] agentic/bug
The regex for feat commits uses !? after the optional scope, meaning a breaking-change commit (feat!: ... or feat(scope)!: ...) is classified as minor instead of major. The conventional-commit spec states that a ! suffix denotes a breaking change which should bump the major version. The ! should be detected as a separate case that sets SPECIFIER=major before the feat branch, or the regex should differentiate it. Additionally, perf: and refactor: types (commonly treated as patch) and chore: are all silently treated as patch by the fallback, which may or may not be intentional — worth documenting.
Suggested fix:
if printf '%s' "$TITLE" | grep -qE '^(feat|fix)(\(.+\))?!:'; then
SPECIFIER=major
elif printf '%s' "$TITLE" | grep -qE '^feat(\(.+\))?:'; then
SPECIFIER=minor
elif printf '%s' "$TITLE" | grep -qE '^fix(\(.+\))?:'; then
SPECIFIER=patch
else
SPECIFIER=patch
fi
| - name: Release | ||
| run: | | ||
| npx nx release --specifier=patch --yes | ||
| npx nx release --specifier=${{ steps.specifier.outputs.specifier }} --yes |
There was a problem hiding this comment.
[WARNING] agentic/security
The step output steps.specifier.outputs.specifier is interpolated directly into the shell command string via ${{ ... }}. Even though the value produced in the run script can only be minor or patch (due to the fixed assignments), GitHub Actions expression injection is a latent risk: if the logic ever changes, or if an attacker can influence the output file ($GITHUB_OUTPUT), the literal string lands unquoted in the shell. The value should be quoted in the shell command to be safe.
Suggested fix:
npx nx release --specifier="${{ steps.specifier.outputs.specifier }}" --yes
Resolve conflicts (develop = complete ethers-free SIWE removal): - src (sign-in, subname-challenge, siwens.ts): keep develop's viem/siwe impl - package.json (sdk, siwens, packages/siwens): keep main's published versions, drop the removed 'siwe' peerDep, keep '@stablelib/random' - yarn.lock: regenerated - release.yml: breaking '!' commits -> major, quote specifier interpolation
This branch was successfully deployed
1 participant
No description provided.