Skip to content

test: live gate for sendFrameTransaction #13

Description

@mariano-aguero

sendFrameTransaction is verified against a stubbed node only. Nothing in the suite proves that bytes this library produces are admitted by a real node, and the strongest evidence available today is ethrex_simulateFrameTransaction returning a recognised prefixShape, which the live suite already checks.

Closing this needs three things that are not in the repository:

  • A sender contract deployed on hegota-testnet whose VERIFY prefix calls APPROVE. A plain EOA sender cannot, so no amount of correct encoding makes an EOA-sent transaction admissible.
  • A key funded from faucet.privacy.ethrex.xyz.
  • A second opt-in environment variable, distinct from FRAMES_LIVE. The existing live suite is documented as unable to alter chain state, and a broadcast test alters it, so folding the two together would break that guarantee.

The gate belongs in vitest.config.ts by configuration rather than by a path filter, for the reason recorded in CONTRIBUTING.md: vitest applies exclude even to a path named on the command line, so an unconditional exclude makes the suite run zero tests and report success.

Not a small task, and not blocking. Context is in docs/OPEN-ITEMS.md, first item.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions