fix(ui): key reverse answers by address and chain - #349
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Findings outside the diff
These sit on lines this PR did not change, but this PR is what makes them wrong. They cannot be posted as inline comments.
- [WARNING]
.github:2— Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: amannn/action-semantic-pull-request@v5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Reviewer callouts (1)
Non-blocking observations. Nothing here needs to change before merge.
.github:1— "The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see actions/runner-images#14748"
4 tasks
Ghadi8
reviewed
Sep 21, 2026
Ghadi8
approved these changes
Sep 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverse resolution answers are filed by address and chain, instead of by address alone.
Why
The request already scopes each address to its chain with an
@eip155:<chainId>suffix, and the dedupe key already carried the chain, but the answers were stored under the lowercased address on its own. A batch spanning two chains collapsed both answers onto one entry, and whichever came back last was rendered on both rows. An address with a name set on Base showed that name on a mainnet transaction.The chain is read back from the
coinTypeeach slot echoes rather than from the slot's position in the response array. Both are documented and the order is stable, but the failure modes differ: by position a mismatch puts a name on a row it was not read for, while by coinType it leaves the address as hex. On a signing screen the failure has to fall toward the hex. A slot whosecoinTypeis null failed before the lookup and has no chain to be filed under, so it is dropped.Closes
N/A
How to test
bun install bunx nx run-many -t typecheck lint test --projects=@jaw.id/ui bunx nx build @jaw.id/uipackages/ui/src/utils/reverseResolve.test.tscovers one address asked on mainnet and on Base, that both still go out in a single request, and that an unplaceable slot is dropped. Reverting the keying line on its own makes the first fail, with the Base name sitting on the mainnet entry.Checklist
nx releasetakes the version bump from its typebunx prettier --check .andbunx nx affected -t lint test typecheck build api-checkpass, which is what CI runs@jaw.id/core's public API is unchanged, orbunx nx api-update @jaw.id/coreran and the report diff is part of this PRprettier --check .passes and every affected task passes except@jaw-mono/keys-jaw-id:test, which fails on Node 25 and later for a reason unrelated to this change. #347 fixes it. The keys of the returned record are internal to@jaw.id/ui, so there is nothing to document.