Skip to content

fix(ui): key reverse answers by address and chain - #349

Merged
Ghadi8 merged 8 commits into
mainfrom
fix/ui-reverse-key-by-chain
Sep 22, 2026
Merged

Ghadi8 merged 8 commits into
mainfrom
fix/ui-reverse-key-by-chain

Conversation

@mariano-aguero

Copy link
Copy Markdown
Contributor

What

Reverse resolution answers are filed by address and chain, instead of by address alone.

Why

The request already scopes each address to its chain with an @eip155:<chainId> suffix, and the dedupe key already carried the chain, but the answers were stored under the lowercased address on its own. A batch spanning two chains collapsed both answers onto one entry, and whichever came back last was rendered on both rows. An address with a name set on Base showed that name on a mainnet transaction.

The chain is read back from the coinType each slot echoes rather than from the slot's position in the response array. Both are documented and the order is stable, but the failure modes differ: by position a mismatch puts a name on a row it was not read for, while by coinType it leaves the address as hex. On a signing screen the failure has to fall toward the hex. A slot whose coinType is null failed before the lookup and has no chain to be filed under, so it is dropped.

Closes

N/A

How to test

bun install
bunx nx run-many -t typecheck lint test --projects=@jaw.id/ui
bunx nx build @jaw.id/ui

packages/ui/src/utils/reverseResolve.test.ts covers one address asked on mainnet and on Base, that both still go out in a single request, and that an unplaceable slot is dropped. Reverting the keying line on its own makes the first fail, with the Base name sitting on the mainnet entry.

Checklist

  • The title is a conventional commit and reads as the subject it becomes on squash. nx release takes the version bump from its type
  • bunx prettier --check . and bunx nx affected -t lint test typecheck build api-check pass, which is what CI runs
  • @jaw.id/core's public API is unchanged, or bunx nx api-update @jaw.id/core ran and the report diff is part of this PR
  • Docs updated, if this changes behaviour somebody integrates against

prettier --check . passes and every affected task passes except @jaw-mono/keys-jaw-id:test, which fails on Node 25 and later for a reason unrelated to this change. #347 fixes it. The keys of the returned record are internal to @jaw.id/ui, so there is nothing to document.

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
demo Ready Ready Preview Sep 22, 2026 8:58am UTC
jaw-docs Ready Ready Preview Sep 22, 2026 8:58am UTC
keys-jaw-id Ready Ready Preview Sep 22, 2026 8:58am UTC
playground Ready Ready Preview Sep 22, 2026 8:58am UTC

Request Review

@justalab-agents justalab-agents Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings outside the diff

These sit on lines this PR did not change, but this PR is what makes them wrong. They cannot be posted as inline comments.

Reviewer callouts (1)

Non-blocking observations. Nothing here needs to change before merge.

  • .github:1 — "The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see actions/runner-images#14748"

Comment thread packages/ui/src/utils/reverseResolve.test.ts Outdated
Comment thread packages/ui/src/components/TransactionDialog/index.tsx Outdated
@mariano-aguero mariano-aguero self-assigned this Sep 21, 2026

This branch was successfully deployed

4 active deployments
Preview – demo 9cd2d1b4 Deployed Sep 22, 2026 by vercel[bot]
Preview – jaw-docs 9cd2d1b4 Deployed Sep 22, 2026 by vercel[bot]
Preview – playground 9cd2d1b4 Deployed Sep 22, 2026 by vercel[bot]
Preview – keys-jaw-id 9cd2d1b4 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants