fix: make the playground responsive on mobile - #350
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Findings outside the diff
These sit on lines this PR did not change, but this PR is what makes them wrong. They cannot be posted as inline comments.
- [WARNING]
.github:2— Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: amannn/action-semantic-pull-request@v5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Reviewer callouts (1)
Non-blocking observations. Nothing here needs to change before merge.
.github:1— "The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see actions/runner-images#14748"
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The playground (
/coreand/wagmi) now works on phones. Below 768px the method list fills the screen,tapping a method opens it full screen with a "‹ Methods" back button, and going back returns you to the
same spot in the list. Desktop looks exactly as before.
Why
The shell used a fixed two-column grid (
334px | 1fr) inside anh-screen overflow-hiddenwrapper. On aphone that left the method panel about 50px wide, so the playground could not be used at all.
The sidebar is the navigation, so mobile shows the list and the detail one at a time instead of hiding
the sidebar in a drawer. The page scrolls normally on mobile instead of inside a locked full-height box.
The Dialog Theme view stacks the controls above the previews rather than using the list/detail flow,
because the two are meant to be used together.
Every mobile change is a
max-md:/max-sm:class, or a base class whose desktop value moved behindmd:, so layout from 768px up is unchanged. The other mobile fixes:anchored to the right of the trigger, ran off the left edge.
it was 343px wide and scrolled sideways on 320px screens.
wallet_revokePermissionswrap.The landing page already fit phone screens and is untouched.
Closes
How to test
bun install bunx nx run-many -t typecheck lint test --projects=@jaw-mono/playground bunx nx build @jaw-mono/playgroundRun bunx nx dev @jaw-mono/playground and check both /core and /wagmi.
Desktop (≥768px): should look exactly as before. Before and after screenshots at 1440, 1024 and 768px are
pixel-identical for the landing page, both SDK pages with a method open, and the Dialog Theme view.
Mobile (devtools at 390px and 320px, or a real phone):
screen, inside the viewport.