Skip to content

Return empty history when snapshots are missing #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Justice989810 merged 2 commits into from
Sep 29, 2026
Merged

Return empty history when snapshots are missing #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
344171b
Return empty score history without snapshots
Niceguy247 Sep 29, 2026
4d4778d
Merge branch 'main' into fix/issue-93-empty-score-history
Justice989810 Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 58 additions & 58 deletions src/components/ScoreTrendChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

export const ScoreTrendChart: React.FC<ScoreTrendChartProps> = ({
snapshots,
account,

Check warning on line 23 in src/components/ScoreTrendChart.tsx

View workflow job for this annotation

GitHub Actions / lint-and-build 

'account' is defined but never used
}) => {
const [timeframe, setTimeframe] = useState<'24H' | '7D' | '30D' | 'ALL'>('30D');
const { theme } = useTheme();
Expand Down Expand Up @@ -76,67 +76,67 @@
</div>

{/* Recharts Curve */}
<div className="w-full h-64">
{snapshots.length === 0 ? (
<div className="h-full flex items-center justify-center text-sm text-[var(--text-secondary)]">
No score history available yet.
</div>
<div className="w-full h-64 flex items-center justify-center">
{filteredData.length === 0 ? (
<p className="text-sm font-mono-tech text-[var(--text-secondary)]">
No score history available for this account.
</p>
) : (
<ResponsiveContainer width="100%" height="100%">
<AreaChart data={filteredData} margin={{ top: 10, right: 10, left: -20, bottom: 0 }}>
<defs>
<linearGradient id="scoreGradient" x1="0" y1="0" x2="0" y2="1">
<stop offset="5%" stopColor={strokeColor} stopOpacity={0.4} />
<stop offset="95%" stopColor={strokeColor} stopOpacity={0.0} />
</linearGradient>
</defs>

<CartesianGrid strokeDasharray="3 3" stroke={gridColor} vertical={false} />

<XAxis
dataKey="date"
stroke={textColor}
tick={{ fontSize: 11, fontFamily: 'monospace' }}
tickLine={false}
axisLine={{ stroke: gridColor }}
/>

<YAxis
domain={[0, 100]}
ticks={[0, 25, 50, 75, 100]}
stroke={textColor}
tick={{ fontSize: 11, fontFamily: 'monospace' }}
tickLine={false}
axisLine={{ stroke: gridColor }}
/>

<Tooltip
content={({ active, payload }) => {
if (active && payload && payload.length) {
const data = payload[0].payload;
return (
<div className="bg-[var(--bg-secondary)] border border-[var(--accent-electric)] p-3 rounded-lg shadow-xl font-mono-tech text-xs">
<p className="text-[var(--text-secondary)] mb-1">{data.fullDate}</p>
<div className="flex items-center gap-2">
<span className="text-[var(--text-secondary)]">Pulse Score:</span>
<span className="text-[var(--accent-electric)] font-bold text-sm">{data.score} / 100</span>
</div>
<AreaChart data={filteredData} margin={{ top: 10, right: 10, left: -20, bottom: 0 }}>
<defs>
<linearGradient id="scoreGradient" x1="0" y1="0" x2="0" y2="1">
<stop offset="5%" stopColor={strokeColor} stopOpacity={0.4} />
<stop offset="95%" stopColor={strokeColor} stopOpacity={0.0} />
</linearGradient>
</defs>

<CartesianGrid strokeDasharray="3 3" stroke={gridColor} vertical={false} />

<XAxis
dataKey="date"
stroke={textColor}
tick={{ fontSize: 11, fontFamily: 'monospace' }}
tickLine={false}
axisLine={{ stroke: gridColor }}
/>

<YAxis
domain={[0, 100]}
ticks={[0, 25, 50, 75, 100]}
stroke={textColor}
tick={{ fontSize: 11, fontFamily: 'monospace' }}
tickLine={false}
axisLine={{ stroke: gridColor }}
/>

<Tooltip
content={({ active, payload }) => {
if (active && payload && payload.length) {
const data = payload[0].payload;
return (
<div className="bg-[var(--bg-secondary)] border border-[var(--accent-electric)] p-3 rounded-lg shadow-xl font-mono-tech text-xs">
<p className="text-[var(--text-secondary)] mb-1">{data.fullDate}</p>
<div className="flex items-center gap-2">
<span className="text-[var(--text-secondary)]">Pulse Score:</span>
<span className="text-[var(--accent-electric)] font-bold text-sm">{data.score} / 100</span>
</div>
);
}
return null;
}}
/>

<Area
type="monotone"
dataKey="score"
stroke={strokeColor}
strokeWidth={2.5}
fillOpacity={1}
fill="url(#scoreGradient)"
/>
</AreaChart>
</div>
);
}
return null;
}}
/>

<Area
type="monotone"
dataKey="score"
stroke={strokeColor}
strokeWidth={2.5}
fillOpacity={1}
fill="url(#scoreGradient)"
/>
</AreaChart>
</ResponsiveContainer>
)}
</div>
Expand Down
Loading