Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new navigation drawer (sidebar) on the Home screen and wires it into Home’s event/effect flow, alongside some PIN-entry handling optimizations.
Changes:
- Added a Home-specific
ModalNavigationDrawer(HomeDrawer) with a newDrawerMenuItemmodel and click handling inHomeViewModel. - Refactored
HomeScreenlayout to wrap content in the new drawer and changed the top-bar menu behavior to open it. - Reduced per-keystroke work in
PinViewModel/BiometricViewModelby deferring validation/authorization until PIN entry is complete.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds a new Home string resource intended for the “show all transactions” CTA. |
| app/src/main/java/com/k689/identid/ui/dashboard/home/HomeViewModel.kt | Adds drawer item click event and navigation handling (e.g., Change PIN flow). |
| app/src/main/java/com/k689/identid/ui/dashboard/home/HomeScreen.kt | Wraps Home UI in HomeDrawer, updates top bar menu behavior, and restructures scaffold content. |
| app/src/main/java/com/k689/identid/ui/dashboard/home/components/HomeDrawer.kt | Introduces the new Home drawer UI component. |
| app/src/main/java/com/k689/identid/ui/dashboard/home/components/DrawerMenuItem.kt | Defines drawer menu entries and routes. |
| app/src/main/java/com/k689/identid/ui/dashboard/dashboard/DashboardScreen.kt | Restores NavHost-based bottom-tab routing structure within the dashboard container. |
| app/src/main/java/com/k689/identid/ui/common/pin/PinViewModel.kt | Optimizes quick PIN handling to validate only when input is complete. |
| app/src/main/java/com/k689/identid/ui/common/biometric/BiometricViewModel.kt | Optimizes quick PIN authorization to run only when input is complete and clears errors when typing resumes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s/HomeDrawer.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/DrawerMenuItem.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Linux123123
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.