Skip to content

Remove TUI codepath and boot straight to GUI - #9

Merged
KEYTRON merged 1 commit into
mainfrom
v3in3v-codex/verify-all-pipelines-and-ci/cd
Nov 14, 2025
Merged

Remove TUI codepath and boot straight to GUI#9
KEYTRON merged 1 commit into
mainfrom
v3in3v-codex/verify-all-pipelines-and-ci/cd

Conversation

@KEYTRON

@KEYTRON KEYTRON commented Nov 14, 2025

Copy link
Copy Markdown
Owner

Summary

  • drop the TUI initialization/demo flow from kernel_main so the kernel only brings up the graphics stack and GUI desktop
  • simplify graphics bring-up logging and stop creating sample GUI widgets ahead of the desktop runtime
  • rename the GRUB entry to "MyOS GUI" to reflect the GUI-only boot option

Testing

  • make -C kernel

Codex Task

@KEYTRON
KEYTRON merged commit 97cc1a5 into main Nov 14, 2025
1 check failed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +20 to +24
- name: Build x86_64 ISO (QEMU exit enabled)
run: |
set -euo pipefail
QEMU_EXIT=1 ./utils/build_iso.sh
ls -l kernel/myos.iso

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Run build_iso.sh from repo root

The new workflow invokes QEMU_EXIT=1 ./utils/build_iso.sh (lines 21‑24) while staying in the repository root, but utils/build_iso.sh immediately does cd ../kernel (line 6 of that script) and therefore assumes it was launched from the utils/ directory. Running it from the root leaves the working directory unchanged, so the cd fails with cd: ../kernel: No such file or directory, after which the subsequent make commands run in the wrong directory and the script exits with an error (reproduced locally with the same command). As a result, the CI job will always fail before producing an ISO. Change the workflow to cd utils (or call the script via bash utils/build_iso.sh after pushd utils) before invoking the script.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant