Remove TUI codepath and boot straight to GUI - #9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Build x86_64 ISO (QEMU exit enabled) | ||
| run: | | ||
| set -euo pipefail | ||
| QEMU_EXIT=1 ./utils/build_iso.sh | ||
| ls -l kernel/myos.iso |
There was a problem hiding this comment.
Run build_iso.sh from repo root
The new workflow invokes QEMU_EXIT=1 ./utils/build_iso.sh (lines 21‑24) while staying in the repository root, but utils/build_iso.sh immediately does cd ../kernel (line 6 of that script) and therefore assumes it was launched from the utils/ directory. Running it from the root leaves the working directory unchanged, so the cd fails with cd: ../kernel: No such file or directory, after which the subsequent make commands run in the wrong directory and the script exits with an error (reproduced locally with the same command). As a result, the CI job will always fail before producing an ISO. Change the workflow to cd utils (or call the script via bash utils/build_iso.sh after pushd utils) before invoking the script.
Useful? React with 👍 / 👎.
Summary
kernel_mainso the kernel only brings up the graphics stack and GUI desktopTesting
make -C kernelCodex Task