Repository navigation
fix(nmea0183, ais): read what real receivers send - #2
Merged
Merged
Conversation
Checked against the gpsd regression logs and the Signal K samples. - Sentences up to 102 bytes are read (MAX_ACCEPTED_BYTES); encode still writes at most 82. VDM payloads up to 80 characters. - A DOP of 0, an empty variation and a variation of 999 or more read as not available instead of refusing the sentence. - AIS headings 360 to 510 read as not available, like 511; the rest of the report is kept. - OutOfRange no longer prints an unbounded limit as hundreds of digits. kinavis-kernel 1.0.1, kinavis-nmea0183 0.1.1, kinavis-ais 0.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked against the gpsd regression logs and the Signal K samples: RMC→fix 2458→2659, refusals 2209→1371, AIS errors 11→0 across 199 gpsd logs.
MAX_ACCEPTED_BYTES);encodestill writes at most 82. VDM payloads up to 80 characters.OutOfRangeno longer prints an unbounded limit as hundreds of digits.kinavis-kernel 1.0.1, kinavis-nmea0183 0.1.1, kinavis-ais 0.1.1.