Do not publish an unchanged index - #24
Merged
Merged
Conversation
Maximilian-Nesslauer
added
area:infra
Maximilian-Nesslauer
requested review from
MrJeranimo,
PlazmaBoltz and
averageksp
August 14, 2026 21:01
MrJeranimo
force-pushed
the
snapshot-unchanged
branch
from
August 30, 2026 23:47
d281f0d to
cda9613
Compare
MrJeranimo
force-pushed
the
snapshot-unchanged
branch
from
August 31, 2026 00:21
cda9613 to
dbee571
Compare
Contributor
|
Validated. A steward has to merge this one, because the change touches no release file. |
MrJeranimo
force-pushed
the
snapshot-unchanged
branch
from
August 31, 2026 00:25
dbee571 to
fab9c84
Compare
MrJeranimo
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23. Needs KSAModding/content-manager-design#46, which corrects the spec text this implements.
sourcescarries the two commit SHAs, so a README edit or a Dependabot bump moved the snapshot bytes with no change in content, and every client re-downloaded.That is the cost the "no wall-clock field" rule in spec/snapshot.md exists to avoid, reintroduced more slowly.
Unchanged content now keeps the published provenance, and the workflow compares against what is published and skips the deploy when the bytes match, because a deployment issues a new ETag either way.