Repository navigation
refactor: replace awk menu strings with TSV + tk_menu_* API - #7
Merged
Merged
Conversation
Step D-4 of the toolkit plan. Replaces the six-layer hand-tuned quoting chain with the vendored menu.sh tk_menu_* API. - Rewrite 4 data awk scripts to emit TSV instead of tmux menu syntax (worktree_data, branch_data, removable_data, stale_data) - Other 6 awk scripts already emitted data-only output (counts, sort) - Delete eval "tmux display-menu -T '$title' $options" - All 6 menu screens now use tk_menu_reset/title/item/show - generate_nav_options replaced by _add_nav_items (side-effect on TK_MENU_ARGS) - Update test helper tmux stub to scan past -L flags from tk_tmux - Update 16 test files for new TSV + tk_menu_* test surface - Add round-trip quoting tests for spaces, apostrophes, forward slashes - All 215 non-E2E tests green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step D-4 of the tmux-toolkit plan. Replaces the six-layer hand-tuned quoting chain with the vendored menu.sh tk_menu_* API.
What changed
Testing
make test # all non-E2E tests pass