This repository was archived by the owner on May 8, 2022. It is now read-only.
Number formater#34
Open
Liador wants to merge 2 commits into
Open
Conversation
Kern046
suggested changes
Dec 15, 2018
Contributor
Kern046
left a comment
Kern046
left a comment
There was a problem hiding this comment.
Il faut que tu aères beaucoup plus ton code et que tu respectes les guidelines sur l'indentation, le respect des accolades etc..
Sinon la méthode formatNumber est beaucoup trop grosse et complexe il faudrait que tu la découpes en plusieurs fonctions plus petites
| } | ||
| if(decimalNumber <= decimalSize) { | ||
| numberLength = newNumber.toString().length-decimalNumber; | ||
| } |
| if(decimalNumber <= decimalSize) { | ||
| numberLength = newNumber.toString().length-decimalNumber; | ||
| } | ||
| else { |
Contributor
There was a problem hiding this comment.
Suggested change
| else { | |
| } else { |
| decimalNumber=decimalSize; | ||
| numberLength= newNumber.toString().length-decimalNumber; | ||
| } | ||
| } |
| numberTemp=Math.floor(numberTemp); | ||
|
|
||
| cpt = 0; | ||
| while (cpt<numberLength) |
Contributor
There was a problem hiding this comment.
remonte l'accolage d'une ligne
| :" ") | ||
| :"") | ||
| ; | ||
| (Math.floor(currentNumberOfTimeUnit)>0||stringSize>0)?stringSize++:cpt=cpt; |
Contributor
There was a problem hiding this comment.
Usine à gaz de la mort sur ces lignes, aère ton code :)
Kern046
force-pushed
the
develop
branch
9 times, most recently
from
9c26d06 to
e9c0657
Compare
Kern046
force-pushed
the
develop
branch
3 times, most recently
from
f1ef68b to
3b8b34b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.