ci: Don't mask docker image build failures#929
Merged
Conversation
The unbuffer wrapper masks the docker build exit status. On the PR #895 run the image rebuild failed with the ar100 size overflow, the step still reported success, and the klippy tests silently ran against the stale docker hub image with outdated dicts, failing with a confusing KeyError instead of the real build error. Drop unbuffer and the expect install. With --progress=plain the output pipes fine through sed and the exit status now propagates through pipefail. Reproduced locally with a failing Dockerfile. Signed-off-by: Rogerio Goncalves <rogerlz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan