Skip to content

Add Phase 2 numerical verification foundation - #1

Merged
Kandil2001 merged 15 commits into
mainfrom
agent/phase2-verification-foundation
Jul 23, 2026
Merged

Add Phase 2 numerical verification foundation#1
Kandil2001 merged 15 commits into
mainfrom
agent/phase2-verification-foundation

Conversation

@Kandil2001

Copy link
Copy Markdown
Owner

What changed

  • adds a CMake/CTest verification build without replacing the existing solver workflow
  • introduces reusable 2D field, compatible discrete-operator, Poisson, and convergence-contract components
  • verifies D(G(phi)) = L(phi) in the interior for the selected operator pair
  • adds a manufactured Poisson problem on 17×17, 33×33, and 65×65 grids
  • checks approximately second-order spatial convergence
  • checks that RBGS and RBSOR reach the same discrete solution
  • adds explicit solver statuses and consecutive convergence checks
  • adds GCC/Clang, Debug/Release, sanitizer-enabled GitHub Actions coverage
  • documents the Phase 2 convergence contract and the next solver-integration step

Why

The current 36-case study records completed executions, but those cases reached their configured maximum outer-iteration limits. This PR creates the verification and convergence foundation needed before changing the production pressure-correction solver or regenerating results.

Impact

The existing src/lid_cavity.cpp, current CSV results, figures, scripts, and main branch behavior are unchanged. This is an additive foundation intended for review before numerical integration.

Validation performed

  • Release CMake build: passed
  • CTest: 3/3 passed
  • AddressSanitizer + UndefinedBehaviorSanitizer build: passed
  • Sanitized CTest: 3/3 passed

Next step after review

Integrate the convergence tracker and dimensionless residual definitions into the existing C++ cavity solver, then tune and converge only the canonical N=32, Re=100, upwind, RBSOR case before changing the wider study.

@Kandil2001
Kandil2001 marked this pull request as ready for review July 23, 2026 08:44
@Kandil2001
Kandil2001 merged commit b7e0182 into main Jul 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant