Add Phase 2 numerical verification foundation - #1
Merged
Conversation
Kandil2001
marked this pull request as ready for review
July 23, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
D(G(phi)) = L(phi)in the interior for the selected operator pairWhy
The current 36-case study records completed executions, but those cases reached their configured maximum outer-iteration limits. This PR creates the verification and convergence foundation needed before changing the production pressure-correction solver or regenerating results.
Impact
The existing
src/lid_cavity.cpp, current CSV results, figures, scripts, andmainbranch behavior are unchanged. This is an additive foundation intended for review before numerical integration.Validation performed
Next step after review
Integrate the convergence tracker and dimensionless residual definitions into the existing C++ cavity solver, then tune and converge only the canonical
N=32,Re=100, upwind, RBSOR case before changing the wider study.