Conversation
Three breaking changes fixed: 1. Trial.__init__: replace broken pandas 3.x index merge with explicit join. merge(left_index=True, right_index=True) with mismatched index types no longer does positional matching in pandas 3.x — replaced with .join() after aligning both sides on the property key/name column. Also adds graceful fallback when label/description fields are absent. 2. _parseProperty_datetime_local: fix tz_localize on tz-aware Timestamps. pandas 3.x parses ISO strings ending with 'Z' as UTC tz-aware objects. Calling tz_localize() on an already-aware Timestamp raises TypeError. Fixed: check tzinfo first; use tz_convert() if already aware. Also replaces legacy "israel" timezone alias (not recognised by Python 3.12 zoneinfo) with the canonical "Asia/Jerusalem". 3. Trial.properties: remove incorrect re-parse of raw metadata. The property was re-reading self._metadata['properties'] using key/value field names that belong to entity attributes, not trial properties. __init__ already stores the correctly parsed result in self._properties; the property now simply returns that. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three breaking changes fixed:
Trial.init: replace broken pandas 3.x index merge with explicit join. merge(left_index=True, right_index=True) with mismatched index types no longer does positional matching in pandas 3.x — replaced with .join() after aligning both sides on the property key/name column. Also adds graceful fallback when label/description fields are absent.
_parseProperty_datetime_local: fix tz_localize on tz-aware Timestamps. pandas 3.x parses ISO strings ending with 'Z' as UTC tz-aware objects. Calling tz_localize() on an already-aware Timestamp raises TypeError. Fixed: check tzinfo first; use tz_convert() if already aware. Also replaces legacy "israel" timezone alias (not recognised by Python 3.12 zoneinfo) with the canonical "Asia/Jerusalem".
Trial.properties: remove incorrect re-parse of raw metadata. The property was re-reading self._metadata['properties'] using key/value field names that belong to entity attributes, not trial properties. init already stores the correctly parsed result in self._properties; the property now simply returns that.