Support npm 12 pack --json output shape in size report - #30
Merged
Conversation
npm 12 changed `npm pack --dry-run --json` from returning an array of
package summaries to an object keyed by package name, so destructuring
the parsed output threw `TypeError: {} is not iterable` and failed
`bun run perf` (which CI runs on every pull request).
Accept both shapes so the report works regardless of the npm version
bundled with the active Node/CI runner.
KayleeWilliams
marked this pull request as ready for review
August 11, 2026 12:39
Runner images still bundle npm 10, which returns the old array shape from `npm pack --json`, so CI would not have exercised the npm 12 object shape this commit handles. Installing npm 12 makes the perf step cover the shape published releases actually run against, and printing the version records which shape was tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm 12 changed
npm pack --dry-run --jsonfrom returning an array ofpackage summaries to an object keyed by package name, so destructuring
the parsed output threw
TypeError: {} is not iterableand failedbun run perf(which CI runs on every pull request).Accept both shapes so the report works regardless of the npm version
bundled with the active Node/CI runner.
Stack created with GitHub Stacks CLI • Give Feedback 💬