Run lint and typecheck in CI - #33
Merged
KayleeWilliams merged 2 commits intoAug 11, 2026
Merged
Conversation
KayleeWilliams
marked this pull request as ready for review
August 11, 2026 12:39
KayleeWilliams
force-pushed
the
KayleeWilliams/ci-lint-typecheck
branch
from
August 11, 2026 12:58
2710e6d to
a81d182
Compare
CI ran build, test and perf but never ran bun run check, so lint and type regressions could land unnoticed. The step runs after the build because benchmarks/joyful.bench.ts imports from dist, which makes typecheck fail on a clean checkout otherwise.
The pull_request branches filter matches a pull request's base branch, so restricting it to main meant stacked pull requests never ran CI at all: each one targets the branch below it rather than main. Dropping the filter means every pull request is checked, not just the bottom of a stack.
KayleeWilliams
force-pushed
the
KayleeWilliams/ci-lint-typecheck
branch
from
August 11, 2026 13:16
a81d182 to
39351f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI ran build, test and perf but never ran bun run check, so lint and
type regressions could land unnoticed.
The step runs after the build because benchmarks/joyful.bench.ts imports
from dist, which makes typecheck fail on a clean checkout otherwise.
Stack created with GitHub Stacks CLI • Give Feedback 💬