feat: browser-based OAuth via server-side relay with nonce#11
Merged
Conversation
Better Auth's /sign-in/social is a POST endpoint returning a redirect URL. The CLI was opening it as a GET URL in the browser, causing a 404. Now POSTs to get the OAuth redirect URL, then opens that in the browser.
Replace direct POST to Better Auth with a server-side flow: CLI opens /cli-auth page in the browser, which POSTs from the same origin (avoiding CORS/CF Access issues). A relay endpoint reads the HttpOnly session cookie and redirects to the CLI callback with the token. A cryptographic nonce is threaded through the entire flow to prevent relay URL forgery.
Switch kh auth login to use device code flow (RFC 8628) by default, matching the pattern used by GitHub CLI. Browser OAuth is available via --browser flag. Device flow avoids CORS, cookie, and Cloudflare Access issues since the browser handles all server communication. Also adds CF-Access header support to device code/token requests for staging environments behind Cloudflare Access.
- Remove --browser flag (server-side relay page was never built) - Delete oauth.go and oauth_test.go - Move ReadTokenFromStdin to device.go - Device flow is the only interactive auth method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go test ./internal/auth/)go build ./...succeedskh auth loginagainst staging (requires KeeperHub PR #562 deployed first)