Conversation
Tapping the mic to stop dictation erased the message: iOS fires a final `result` with an empty transcript on `stop()`, and `applyTranscript` treats an empty transcript as a reset to the pre-dictation draft. The interim results had already landed the real words, so the empty final could only erase them. Drop empty transcripts in the dictation handler, where the draft is known, rather than in the pure merge rule. With that fixed, wire the send arrow to appear while still dictating: it now shows as soon as the draft is non-empty, and tapping it cancels the recogniser (releasing the mic) before sending. Speaking a message and sending it is one tap instead of stop-then-send.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping the mic to stop dictation erased the message: iOS fires a final
resultwith an empty transcript onstop(), andapplyTranscripttreats an empty transcript as a reset to the pre-dictation draft. The interim results had already landed the real words, so the empty final could only erase them. Drop empty transcripts in the dictation handler, where the draft is known, rather than in the pure merge rule.With that fixed, wire the send arrow to appear while still dictating: it now shows as soon as the draft is non-empty, and tapping it cancels the recogniser (releasing the mic) before sending. Speaking a message and sending it is one tap instead of stop-then-send.