Skip to content

Sup-1821-toolkit _scorecard_fix_v3#596

Merged
effany merged 15 commits intomainfrom
SUP-1821-toolkit-scorecard-fix-v3
Jul 17, 2025
Merged

Sup-1821-toolkit _scorecard_fix_v3#596
effany merged 15 commits intomainfrom
SUP-1821-toolkit-scorecard-fix-v3

Conversation

@effany
Copy link
Contributor

@effany effany commented Jul 10, 2025

customer's task is facing 404 error due to endpoint change.

However, I also notice that how we're retrieving data is fundamentally wrong anyway....

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.23%. Comparing base (83be5d8) to head (f8d63c3).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   32.53%   34.23%   +1.70%     
==========================================
  Files         128      128              
  Lines        8458     8461       +3     
==========================================
+ Hits         2752     2897     +145     
+ Misses       5706     5564     -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effany effany requested review from ababhis2 and jgarber-cisco July 11, 2025 14:03
@effany effany requested a review from abhiuee July 14, 2025 07:47
jgarber-cisco
jgarber-cisco previously approved these changes Jul 15, 2025
Copy link
Contributor

@jgarber-cisco jgarber-cisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the speculative nil checks and parser error handling was removed, but it's in good company with what already exists.

ababhis2
ababhis2 previously approved these changes Jul 15, 2025
@effany effany dismissed stale reviews from ababhis2 and jgarber-cisco via a901ed8 July 16, 2025 07:01
@effany effany requested a review from ababhis2 July 17, 2025 07:20
@effany effany merged commit 3da6b81 into main Jul 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants