Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 32.53% 34.23% +1.70%
==========================================
Files 128 128
Lines 8458 8461 +3
==========================================
+ Hits 2752 2897 +145
+ Misses 5706 5564 -142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abhiuee
reviewed
Jul 11, 2025
jgarber-cisco
previously approved these changes
Jul 15, 2025
Contributor
jgarber-cisco
left a comment
There was a problem hiding this comment.
I'd prefer the speculative nil checks and parser error handling was removed, but it's in good company with what already exists.
ababhis2
previously approved these changes
Jul 15, 2025
ababhis2
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
customer's task is facing 404 error due to endpoint change.
However, I also notice that how we're retrieving data is fundamentally wrong anyway....