This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Added persistent cookie storage to avoid having to renew the session … - #1
Open
sco01 wants to merge 1 commit into
Open
Added persistent cookie storage to avoid having to renew the session …#1sco01 wants to merge 1 commit into
sco01 wants to merge 1 commit into
Conversation
…for each invocation
Owner
|
Hi, thanks so much for contributing. Maybe you could make the cookie file path an argument when instantiating a new Rarbg object, so we dont always have to use the cookies file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for each new session.
The PR will try to store the session cookies after a successful renew_session() into a file. Each following get_resp() will try to load the cookies from the file instead of renewing the session cookies. This saves about 4.5 seconds when establishing a new session and will do so until the cookies expire and a new renew_session() is called.
Please let me know if there is anything you would like me to improve and a big thanks for making this available!
Regards,
Stefan