Fourier Holographically Reduced Representations

[MichielStock]

Implements FHRR, a work in progress.

Contains complex HV, easy to encode numbers

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

Runic

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L186-L187

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L189-L189

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L195-L195

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L197-L197

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L203-L203

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L209-L209

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L214-L215

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L234-L234

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L254-L254

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L290-L290

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L295-L295

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L300-L300

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/operations.jl#L318-L318

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L28-L28

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L32-L32

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L52-L52

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L71-L71

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L90-L90

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L101-L101

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L105-L105

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L120-L120

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L125-L125

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L149-L149

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L154-L154

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L170-L170

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/src/types.jl#L176-L177

---

[Runic] _{reported by reviewdog 🐶}

https://github.com/MichielStock/HyperdimensionalComputing.jl/blob/5ade5a37086e0811e38045208284af4c91c3f52f/test/operations.jl#L55-L55

[cvigilv]

I haven't read a lot of this kind of VSA, so I can't really comment on if this is properly implemented. Apart from that, code looks good, so no comment on that side.

A question regarding naming conventions: up until now we have used "generic" naming conventions for the different VSA, for example, BinaryHV refers to the Binary Splatter Code of Kanerva, or TernaryHV refers to the MAP VSA. This new HV type would break this convention (i think) and we could rename it to "ComplexHV" maybe? I'm unsure what to do with this aspect of the package, since (i) it would be useful to comply with the VSA names, but (ii) its more intuitive to think of this hypervectors based on the kind of values they store (this is the convention I think we are using now).

LMKWYT

[MichielStock]

This is still a work in process and requires some tuning. Haven't decided on the proper way of encoding numbers (for which this should be most suited). Would require some work.

Name might not be ideal. Does not follow our convention, though I would prefer it to be recognizable.

Maybe FHRRHDVor FourierHDV?

[cvigilv]

Mmm, unsure what to make of this. I would need to think about it to see what makes sense.

In my opinion, there is no need to adding all the VSA that exist, but it could be nice to have at least one for each numerical type (Bool, Int, Float, Complex, etc.). I think this is friendlier for newcomers but not that much for experts (maybe this is a question Denis Kleyko could help us answer)

[MichielStock]

This is an important one to add. Will work furth on it after merging #40 in main so I can streamline the API.

Will rename it ComplexHV with an alias to FHRRHV.

[cvigilv]

This looks great! I'll push merging #40 ASAP so we can add this