Skip to content

Addressing PR comments - #30

Merged
KevinTCoughlin merged 3 commits into
mainfrom
copilot/support-nipper-community-map-weekends
Mar 17, 2026
Merged

Addressing PR comments#30
KevinTCoughlin merged 3 commits into
mainfrom
copilot/support-nipper-community-map-weekends

Conversation

Copilot AI commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI requested a review from KevinTCoughlin March 13, 2026 21:27
Claude AI added a commit that referenced this pull request Mar 15, 2026
- Add config/mapcycle-dust2.txt with de_dust2 map
- Add MAPCYCLE env var support in entrypoint.sh (defaults to mapcycle.txt)
- Update Containerfile to copy mapcycle*.txt files
- Add mapcycle-dust2.txt bind mounts in compose.yml, quadlet, and install.sh
- Create .github/workflows/friday-dust2.yml for Friday PST announcements
- Document Friday Dust 2 rotation and gameplay rules in README.md
- Update CLAUDE.md with Friday Dust 2 feature documentation

Similar to PR #30's MAPCYCLE implementation. Follows common de_dust2
public server gameplay rules from CS 1.6 community standards.

Co-authored-by: KevinTCoughlin <706967+KevinTCoughlin@users.noreply.github.com>
@KevinTCoughlin

Copy link
Copy Markdown
Owner

@claude[agent] recreate off latest

Copilot AI and others added 2 commits March 15, 2026 03:03
Add configurable mapcycle file selection via MAPCYCLE environment
variable, enabling community map weekends with Nipper/community
scoutzknivez variants.

- Add MAPCYCLE env var to entrypoint.sh (default: mapcycle.txt)
- Add +mapcyclefile arg to HLDS command line
- Create config/mapcycle-nipper.txt with community SK variants
- Update Containerfile to copy all mapcycle files (glob pattern)
- Wire MAPCYCLE through compose.yml, compose.windows.yml, quadlet
- Update install.sh for both Podman and Docker paths
- Document in README.md and CLAUDE.md

Co-authored-by: KevinTCoughlin <706967+KevinTCoughlin@users.noreply.github.com>
@Claude
Claude AI force-pushed the copilot/support-nipper-community-map-weekends branch from 5c89b55 to 1be8194 Compare March 15, 2026 03:05
@Claude

Claude AI commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

@claude[agent] recreate off latest

Done! Rebased PR on latest main (1be8194). Resolved merge conflicts by combining both Friday Dust 2 and Community Map Weekends features - both mapcycle-dust2.txt and mapcycle-nipper.txt are now supported. All linters pass.

@Claude Claude AI changed the title feat: support Nipper community map weekends via MAPCYCLE env var Addressing PR comments Mar 15, 2026
@KevinTCoughlin
KevinTCoughlin marked this pull request as ready for review March 17, 2026 14:47
Copilot AI review requested due to automatic review settings March 17, 2026 14:47
@KevinTCoughlin
KevinTCoughlin merged commit 81e2364 into main Mar 17, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for a “community/Nipper” map rotation across deployment methods (Quadlet, Podman Compose, Docker, and Windows overrides) by introducing mapcycle-nipper.txt and ensuring it’s available where MAPCYCLE can reference it.

Changes:

  • Add new config/mapcycle-nipper.txt community rotation file.
  • Bind-mount mapcycle-nipper.txt in Quadlet, Podman Compose, and Docker run/install paths.
  • Document the new rotation and usage via MAPCYCLE in README/CLAUDE, and explicitly set MAPCYCLE=mapcycle.txt in the Windows compose override.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
quadlet/scoutzknivez.container Mounts mapcycle-nipper.txt into the container so MAPCYCLE=mapcycle-nipper.txt works under Quadlet.
install.sh Creates a default mapcycle-nipper.txt in the user config dir and mounts it for Podman Quadlet and Docker run.
config/mapcycle-nipper.txt Introduces the community/Nipper rotation list shipped with the repo/image.
compose.yml Adds bind mount for config/mapcycle-nipper.txt so it’s available when selected via MAPCYCLE.
compose.windows.yml Explicitly sets MAPCYCLE=mapcycle.txt in the Windows override environment.
README.md Documents the new mapcycle file and adds “Community Map Weekends” usage instructions.
CLAUDE.md Updates project layout and env var docs to include mapcycle-nipper.txt.

@KevinTCoughlin
KevinTCoughlin deleted the copilot/support-nipper-community-map-weekends branch May 9, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants