feat(dashboard): 移除侧边栏搜索按钮#2212
Merged
Merged
Conversation
侧边栏搜索按钮(btn-sidebar-search + `/` 快捷键)仅过滤侧边栏内 的会话列表,作用有限。移除整个 UX-P3 sidebar-search 特性: - HTML: 删除 header 中的搜索按钮、搜索输入面板及相关 CSS (.sidebar-search*, .session-list-filter-empty) - JS: 删除 toggleSidebarSearch/closeSidebarSearch/initSidebarSearch/ readSidebarSearchQuery/filterSessionsByQuery 及其 bindClick/init 调用; renderSidebar 不再读取过滤查询,直接走项目分组渲染 - 删除 `/` 全局快捷键 - 同步移除相关契约测试(static_ux_contract_test.go 两个 SidebarSearch 用例、dashboard_csp_test.go 两条绑定项)与 e2e 用例 go build / go vet / 全量 internal/server 测试 / mobile_render e2e 均通过。
Owner
Author
Owner
Author
PR #2212 review (human)
FindingsNo findings. 验证(针对 PR#2184 孤儿引用失败模式重点核查):
VERDICT: PASS |
# Conflicts: # internal/server/dashboard_csp_test.go # internal/server/static/dashboard.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
侧边栏顶部的搜索按钮(放大镜图标 +
/快捷键)只能过滤侧边栏内已有的会话列表,作用范围有限,体验价值不高。本 PR 移除整个 UX-P3 sidebar-search 特性。改动
dashboard.html):删除 header 中的#btn-sidebar-search按钮、#sidebar-search输入面板,以及相关 CSS(.sidebar-search*、.session-list-filter-empty)。dashboard.js):toggleSidebarSearch/closeSidebarSearch/initSidebarSearch/readSidebarSearchQuery/filterSessionsByQuery及其bindClick、initSidebarSearch()调用。renderSidebar不再读取过滤查询,直接走项目分组渲染(保留_lastSidebarData缓存,其余路径仍在使用)。/全局快捷键。static_ux_contract_test.go的两个 SidebarSearch 用例、dashboard_csp_test.gocontrols 表中的两条绑定项,以及mobile_render.test.js中针对搜索去抖的 e2e 用例。验证
go build ./...✅go vet ./internal/server/✅go test ./internal/server/(全量)✅playwright test mobile_render.test.js✅