feat(dashboard): 移除设置里不可配置的「连接」节#2217
Merged
Merged
Conversation
The 设置 view's 连接 section was a read-only connection-status mirror (node name + status dot) with nothing to configure — the actual switch lives in the sidebar node selector. Drop it to declutter the settings view, leaving only the 主题 section. Also removes now-dead code: railConnLabel/RAIL_CONN_LABELS, the .settings-conn/.settings-conn-meta CSS, and the .ab-conn-dot rules (its only remaining consumer was this section).
Owner
Author
|
对抗性 review：LGTM，零 finding。移除设置里不可配置的「连接」节，无孤儿 JS 引用（无 querySelector 指向已删元素 ID、无 settings save/load 迭代已删节），纯净删除。 |
Owner
Author
PR #2217 review (human)
FindingsNo findings. 纯删除 PR，无遗留逻辑。 验证：
VERDICT: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
设置页里的「连接」节只是只读的连接状态镜像（节点名 + 状态点），没有任何可配置项 —— 真正的节点切换在侧栏顶部的节点选择器里。因为无法在此设置，按需求清除掉。
改动
renderSettingsView中的「连接」section（含多节点提示connMeta），只保留「主题」section。railConnLabel/RAIL_CONN_LABELS.settings-conn/.settings-conn-meta，以及唯一消费者已消失的.ab-conn-dot*规则getNodeStatus/getNodeDisplayName/isMultiNode仍被多节点选择器等处使用，保留不动。测试
go build ./...通过go test ./internal/server/静态契约 / 视图路由 / UX ratchet 相关测试全绿（renderSettingsView契约仍满足）🤖 Generated with Claude Code