fix(review): 9 即修 + 13 issue (cron-cr v9 第三轮)#2239
Merged
Conversation
added 9 commits
June 21, 2026 14:39
…solves to one entry [R202606c-CR-001]
…ker [R202606c-ARCH-2] The two metaPathFor implementations (store.go, tracker.go) were verified byte-for-byte equivalent, so this is a pure consolidation with no behavioral change. Export store's as MetaPathFor and have the tracker call it, removing the drift risk that could silently split the .meta namespace between GC and the tracker.
…ng [R202606c-SEC-1]
…of leaking [R202606c-GO-006]
…ing key [R202606c-GO-002]
…p new binding [R202606c-CR-002]
Owner
Author
PR #2239 review (cron)
Findings[NIT] 陈旧注释与修复矛盾: internal/project/manager.go:216 — 注释称 "this block runs before m.mu.Lock()",但 CR-002 已把 m.mu.Lock() 上移至 Scan() 顶部(line 121),CreatedAt 迁移块现已在锁内运行;建议下轮修正注释。 8 项修复均实质正确:
无 CRITICAL/HIGH/MEDIUM/LOW,仅 1 NIT(cosmetic)。 VERDICT: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v9 第三轮全面 code review: 5-reviewer / strict file:line dedup / cosmetic 过滤 / 限额满则塞满。本轮聚焦 attachment/transcribe/project/weixin/upstream/node/sysession 等前两轮未深审模块。
即修 (9 commits = 8 fix + 1 cosmetic)
全部受影响包
go test -race通过 (transcribe/project/attachment/weixin/upstream/dashboard·project)。cosmetic-backlog 追加 5 行。余项 issue (13)
bug/correctness: #2226 #2227
perf: #2228 #2230 #2231 #2232 #2233
sec: #2229 #2234 #2235 #2238
design (needs-design): #2236 #2237
CR-002 经 fix agent 深挖发现 Scan() 本身在锁外做磁盘加载,已一并将整个 Scan body 纳入锁,附 200 轮并发回归测试。