Skip to content

fix(app): return InitChainer errors instead of panics #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
namedfarouk wants to merge 2 commits into from
Closed

fix(app): return InitChainer errors instead of panics #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dea1e1
fix(app): return InitChainer errors instead of panics
namedfarouk Apr 4, 2026
f3aef40
test(app): assert nil InitChainer response on invalid genesis
namedfarouk Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,16 +378,16 @@ func (app *KiichainApp) EndBlocker(ctx sdk.Context) (sdk.EndBlock, error) {
func (app *KiichainApp) InitChainer(ctx sdk.Context, req *abci.RequestInitChain) (*abci.ResponseInitChain, error) {
var genesisState GenesisState
if err := tmjson.Unmarshal(req.AppStateBytes, &genesisState); err != nil {
panic(err)
return nil, fmt.Errorf("failed to unmarshal genesis state: %w", err)
}

if err := app.UpgradeKeeper.SetModuleVersionMap(ctx, app.mm.GetVersionMap()); err != nil {
panic(err)
return nil, fmt.Errorf("failed to set module version map: %w", err)
}

response, err := app.mm.InitGenesis(ctx, app.appCodec, genesisState)
if err != nil {
panic(err)
return nil, fmt.Errorf("failed to initialize genesis: %w", err)
}

return response, nil
Expand Down
20 changes: 20 additions & 0 deletions app/app_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (

"github.com/stretchr/testify/require"

abci "github.com/cometbft/cometbft/abci/types"
db "github.com/cosmos/cosmos-db"

"cosmossdk.io/log"
Expand Down Expand Up @@ -49,3 +50,22 @@ func TestKiichainApp_Export(t *testing.T) {
_, err := app.ExportAppStateAndValidators(true, []string{}, []string{})
require.NoError(t, err, "ExportAppStateAndValidators should not have an error")
}

func TestKiichainApp_InitChainerReturnsErrorForInvalidGenesisJSON(t *testing.T) {
app := kiihelpers.Setup(t)

req := &abci.RequestInitChain{
AppStateBytes: []byte("{ invalid json }"),
}

var (
resp *abci.ResponseInitChain
err error
)
require.NotPanics(t, func() {
resp, err = app.InitChainer(app.NewContext(false), req)
})
require.Nil(t, resp)
require.Error(t, err)
require.ErrorContains(t, err, "failed to unmarshal genesis state")
}