Skip to content

fix(code-indexing): use sha256 for Milvus IDs#3836

Open
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
fix/codeql-232-milvus-sha256-ids
Open

fix(code-indexing): use sha256 for Milvus IDs#3836
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
fix/codeql-232-milvus-sha256-ids

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces MD5 with SHA-256 for deterministic Milvus chunk IDs to resolve CodeQL alert 232.
  • Keeps ID generation deterministic and within the existing 64-character Milvus primary key limit.

Verification

N/A; code-only hashing change with no meaningful manual flow to exercise in this environment.

Visual Changes

N/A

Reviewer Notes

  • Scope intentionally limited to CodeQL alert 232 in apps/web/src/lib/code-indexing/milvus-storage.ts.
  • Existing documents keep their old IDs until files are reindexed; reindexing deletes by file path before upserting new SHA-256 IDs.

@kilo-code-bot
kilo-code-bot Bot requested a review from RSO June 9, 2026 09:32
@github-actions

Copy link
Copy Markdown
Contributor

This Pull Request has been inactive for 30 days and will be closed in 7 days if no further activity occurs. Please update or close this PR if it is no longer relevant.

@github-actions github-actions Bot added the stale label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants