Skip to content

fix(admin): escape HogQL backslashes #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RSO merged 1 commit into from
Jun 9, 2026
Merged

fix(admin): escape HogQL backslashes #3838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/web/src/routers/admin-feature-interest-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ const DetailInputSchema = z.object({
offset: z.number().min(0).default(0),
});

const escapeHogQLStringLiteral = (value: string) =>
value.replace(/\\/g, '\\\\').replace(/'/g, "\\'");

export const adminFeatureInterestRouter = createTRPCRouter({
// Feature Interest Leaderboard
list: adminProcedure.query(async () => {
Expand Down Expand Up @@ -158,9 +161,8 @@ export const adminFeatureInterestRouter = createTRPCRouter({
// When only slug is provided (from Signups by Feature Page), search by feature_slug property
const featureName = nameParam ?? slug;

// Escape single quotes in the feature name for the SQL query
const escapedValue = featureName.replace(/'/g, "\\'");
const escapedSlug = slug.replace(/'/g, "\\'");
const escapedValue = escapeHogQLStringLiteral(featureName);
const escapedSlug = escapeHogQLStringLiteral(slug);

// Build the WHERE condition based on search type
// Use LIKE for partial matching to capture all variations of feature names
Expand Down