Skip to content

fix(auth): remove device code random bias #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RSO merged 1 commit into from
Jun 9, 2026
Merged

fix(auth): remove device code random bias #3849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions apps/web/src/lib/device-auth/device-auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { db } from '@/lib/drizzle';
import { device_auth_requests, kilocode_users } from '@kilocode/db/schema';
import { eq, and, lt, sql } from 'drizzle-orm';
import { generateApiToken } from '@/lib/tokens';
import { randomBytes } from 'node:crypto';
import { randomInt } from 'node:crypto';

const CODE_LENGTH = 8;
const CODE_EXPIRATION_MINUTES = 10;
Expand All @@ -15,11 +15,9 @@ const MAX_PENDING_REQUESTS_PER_IP = 5;
*/
export function generateDeviceCode(): string {
const chars = 'ABCDEFGHJKLMNPQRSTUVWXYZ23456789';
const buf = randomBytes(CODE_LENGTH);
let code = '';
for (let i = 0; i < buf.length; i++) {
const index = buf[i] % chars.length;
code += chars[index];
for (let i = 0; i < CODE_LENGTH; i++) {
code += chars.charAt(randomInt(chars.length));
}
// Format as XXXX-XXXX (8 characters total)
return `${code.slice(0, 4)}-${code.slice(4)}`;
Expand Down