feat(mobile): add chat link actions#4576
Open
iscekic wants to merge 3 commits into
Open
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the full diff (11 files, ~630 lines) adding a chat link-actions sheet and retryable external-link opening; no high-confidence security, correctness, or breaking-API issues were found in the changed lines. Files Reviewed (11 files)
Reviewed by claude-sonnet-5 · Input: 24 · Output: 17.8K · Cached: 625.6K Review guidance: REVIEW.md from base branch |
jeanduplessis
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a native
Link actionssheet when long-pressing a rendered markdown link in both mobile chat experiences (agent-session messages and Kilo Chat), without changing normal tap behavior or the enclosing message's long-press behavior.Open link,Copy link,Share link,Cancel, with the exact destination URL (including query/fragment) shown and acted upon.MarkdownTextstays generic and opt-in via a newonLongPressLinkcallback; only the three chat call sites use the newChatMarkdownTextwrapper.security-agent/finding-analysis-panel.tsxis unchanged.Try again, isolated per-operation. Share dismissal is not treated as a failure.accessibilityRole="link", get anOpens in browserhint, and expose aShow link actionscustom accessibility action when link actions are enabled.Design & Plan
Feature-state matrix
react-native-markedemits a link with anhref.Checks
A fresh, independent code review of the full diff reported no valid actionable findings.
Device E2E
Device E2E for this feature was blocked by two reproducible, pre-existing environment issues unrelated to this diff (no auth or networking files are touched here):
This was investigated at length (see session evidence: nextjs request logs, screenshots, accessibility-tree dumps) and accepted as an environment blocker by the requesting human rather than a product regression. The automated suite above is the primary verification for this PR; device acceptance should be re-run once the local iOS/Android E2E environment issue is resolved.
Non-goals
Copy textaction.